-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: use correct href for phishing page proceed anyway button #36871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e22fdb4]
UI Startup Metrics (1232 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e22fdb4]
UI Startup Metrics (1248 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [80bac5e]
UI Startup Metrics (1258 ± 70 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [879d2b4]
UI Startup Metrics (1236 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice win
593c5dd
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [593c5dd]
UI Startup Metrics (1296 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [fa8fc5c]
UI Startup Metrics (1268 ± 101 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f5dc4d9]
UI Startup Metrics (1295 ± 99 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [dd1fcf5]
UI Startup Metrics (1332 ± 89 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [6eebe10]
UI Startup Metrics (1240 ± 86 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR makes several small optimizations and bug fixes to the way we capture metrics and display URLs for our phishing page.
hostnamenow. Previously, blockedUrl being set todetails.initiatorwould add ahttps://prefix to our metrics (when it was a c2) whereas onlyhostnamewould be tracked otherwiseChangelog
CHANGELOG entry: fix: use correct href for phishing page proceed anyway button
Screenshots/Recordings
Before
Website blocked by c2:
After
Website blocked by c2:
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Fixes phishing warning redirect params by using full href, deriving hostname safely, and handling c2-initiated requests.
blockedUrlfromhrefinstead ofhostname.blockedUrltodetails.initiator; deriveblockedHostnamevianew URL(blockedUrl).hostnamewith fallback to originalhostname/hrefon parse failure.hostname: blockedHostnameandhref: blockedUrlto drive page display and "proceed anyway" link.Written by Cursor Bugbot for commit 6eebe10. This will update automatically on new commits. Configure here.