Skip to content

Conversation

@mindofmar
Copy link
Contributor

@mindofmar mindofmar commented Oct 14, 2025

Description

This PR makes several small optimizations and bug fixes to the way we capture metrics and display URLs for our phishing page.

  • Improves consistency: Metrics always uses hostname now. Previously, blockedUrl being set to details.initiator would add a https:// prefix to our metrics (when it was a c2) whereas only hostname would be tracked otherwise
  • Bug fix: for c2 domain blocks, we previously would display the c2 itself on the phishing page and as the 'Proceed anyway' link. This PR changes it to use the actual domain that the request came from, in order to improve clarity for the user.
  • Bug fix: Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6038

Changelog

CHANGELOG entry: fix: use correct href for phishing page proceed anyway button

Open in GitHub Codespaces

Screenshots/Recordings

Before

Website blocked by c2:

image

After

Website blocked by c2:

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Fixes phishing warning redirect params by using full href, deriving hostname safely, and handling c2-initiated requests.

  • Phishing detection (app/scripts/background.js):
    • Initialize blockedUrl from href instead of hostname.
    • For c2-detected blocks, set blockedUrl to details.initiator; derive blockedHostname via new URL(blockedUrl).hostname with fallback to original hostname/href on parse failure.
    • Build phishing warning redirect hash with hostname: blockedHostname and href: blockedUrl to drive page display and "proceed anyway" link.
    • Minor: add clarifying comments; no API surface changes.

Written by Cursor Bugbot for commit 6eebe10. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-product-safety Push issues to Product Safety team label Oct 14, 2025
@mindofmar mindofmar marked this pull request as ready for review October 14, 2025 22:01
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 14, 2025
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: e22fdb4 | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±73ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±69ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 73ms 1.00s 1.32s 1.26s 1.32s
domContentLoaded 730ms 69ms 693ms 1.00s 937ms 1.00s
firstPaint 75ms 12ms 56ms 176ms 84ms 176ms
firstContentfulPaint 75ms 12ms 56ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [e22fdb4]
UI Startup Metrics (1232 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1232110613616412821346
load106196611975811031157
domContentLoaded105696411945710961152
domInteractive17134861734
firstPaint61588119743710741140
backgroundConnect2522373049255271
firstReactRender2618143132541
getState12590101228
initialActions40254413
loadScripts80970594057845907
setupStore86233913
WebpackHomeuiStartup814700109568831940
load62557793967634797
domContentLoaded61857192165628790
domInteractive1711192191442
firstPaint19256960192187598
backgroundConnect20104862330
firstReactRender271784103240
getState841931012
initialActions208237
loadScripts61556991163627779
setupStore84172911
FirefoxBrowserifyHomeuiStartup13771196191013314421713
load1174103414448712411323
domContentLoaded1174103314438712411322
domInteractive98323736099251
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2918113173187
firstReactRender29253833036
getState10320027527
initialActions4014515212
loadScripts1151101413508212071294
setupStore12416823654
WebpackHomeuiStartup1478130519099215211637
load1296116215106713441412
domContentLoaded1295116215106713441411
domInteractive903424535102162
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3018106153367
firstReactRender322474123370
getState629810513
initialActions401701729
loadScripts1272114714826413141388
setupStore73426624
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 86 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: e22fdb4 | Date: 10/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±46ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 722ms (±41ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±15ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 46ms 1.01s 1.40s 1.07s 1.40s
domContentLoaded 722ms 41ms 703ms 1.05s 753ms 1.05s
firstPaint 77ms 15ms 60ms 216ms 84ms 216ms
firstContentfulPaint 77ms 15ms 60ms 216ms 84ms 216ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [e22fdb4]
UI Startup Metrics (1248 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1248112314086513021361
load107197512145611121172
domContentLoaded106497212105511061165
domInteractive18146581740
firstPaint71190122443310871171
backgroundConnect25523832312259272
firstReactRender26195772741
getState1357391729
initialActions41275513
loadScripts81673296654850916
setupStore1053441017
WebpackHomeuiStartup803696103968817948
load62157589866626777
domContentLoaded61356988165621769
domInteractive15116391334
firstPaint19555904189191595
backgroundConnect20104972330
firstReactRender2716114113135
getState84203914
initialActions2011236
loadScripts61056787063619759
setupStore84162912
FirefoxBrowserifyHomeuiStartup14151211187112714841678
load1212103815659712921370
domContentLoaded1212103815659712911370
domInteractive103343646194271
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect29198093345
firstReactRender30255053141
getState73779515
initialActions30788212
loadScripts1191102015259412701344
setupStore12420926747
WebpackHomeuiStartup15571361198212815881839
load1349121517169213881538
domContentLoaded1348121417169213871538
domInteractive993236567102326
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect311892113546
firstReactRender372681143776
getState9211219657
initialActions5012915222
loadScripts1325119816939013701516
setupStore10414417741
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 86 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 80bac5e | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±82ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±41ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 70ms 993ms 1.31s 1.23s 1.31s
domContentLoaded 730ms 82ms 692ms 1.26s 921ms 1.26s
firstPaint 80ms 41ms 60ms 484ms 92ms 484ms
firstContentfulPaint 80ms 41ms 60ms 484ms 92ms 484ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [80bac5e]
UI Startup Metrics (1258 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1258109914827013081374
load108096112776711311198
domContentLoaded107495512726611261192
domInteractive18145271740
firstPaint70688121243411131186
backgroundConnect2542422797258267
firstReactRender27185572944
getState1555072028
initialActions61306718
loadScripts826714101165880942
setupStore1163251223
WebpackHomeuiStartup854714111067870967
load64258191467645790
domContentLoaded63357590566640782
domInteractive161268101541
firstPaint19455915186200635
backgroundConnect23124172937
firstReactRender28176783335
getState941731215
initialActions319246
loadScripts63057389464638772
setupStore1162731316
FirefoxBrowserifyHomeuiStartup14161221179310814491647
load1206105613857512501343
domContentLoaded1206105513857512501342
domInteractive1083328047114223
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect32207183844
firstReactRender25216552635
getState1038310819
initialActions41344310
loadScripts1185104013697512321325
setupStore145181231126
WebpackHomeuiStartup15581407193010216001797
load1341118416489013941528
domContentLoaded1341118416479013941526
domInteractive98303816094233
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect351982114055
firstReactRender34268393646
getState9313313814
initialActions41365313
loadScripts1319116616258913691501
setupStore1166181133
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -70.01 KiB (-1.54%)
  • ui: 10.86 KiB (0.17%)
  • common: 70.9 KiB (0.85%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 879d2b4 | Date: 10/17/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±76ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 742ms (±87ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±43ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 76ms 1.01s 1.37s 1.31s 1.37s
domContentLoaded 742ms 87ms 702ms 1.30s 987ms 1.30s
firstPaint 80ms 43ms 64ms 504ms 88ms 504ms
firstContentfulPaint 80ms 43ms 64ms 504ms 88ms 504ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [879d2b4]
UI Startup Metrics (1236 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1236112614106212671366
load106397312295310921163
domContentLoaded105796912265210891149
domInteractive1914138181737
firstPaint67671117543210731157
backgroundConnect2552403008257270
firstReactRender25194152537
getState1565591837
initialActions51668617
loadScripts80872395950836894
setupStore1063041120
WebpackHomeuiStartup8217001098708371039
load62056793664628785
domContentLoaded61256392463620776
domInteractive15116291341
firstPaint18957925170189588
backgroundConnect21114062632
firstReactRender2816240223134
getState942331113
initialActions3015246
loadScripts60956191361618766
setupStore1052531214
FirefoxBrowserifyHomeuiStartup14901295212313315421758
load1267111215418513311393
domContentLoaded1267111115418513311393
domInteractive1163539157125250
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3619155164055
firstReactRender26217362637
getState94284916
initialActions6117318411
loadScripts1243109215158413111376
setupStore175219361053
WebpackHomeuiStartup15691359211013216111838
load1341118416579313951545
domContentLoaded1341118316579313951545
domInteractive1153538775111359
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3618137173975
firstReactRender312292153077
getState11416221818
initialActions41304312
loadScripts1318115915538813711523
setupStore136130191049
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -44.82 KiB (-0.99%)
  • ui: 10.86 KiB (0.17%)
  • common: 73.2 KiB (0.88%)

AugmentedMode
AugmentedMode previously approved these changes Oct 23, 2025
Copy link
Contributor

@AugmentedMode AugmentedMode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice win

imblue-dabadee
imblue-dabadee previously approved these changes Oct 24, 2025
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 593c5dd | Date: 10/27/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±45ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±40ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 45ms 1.01s 1.34s 1.06s 1.34s
domContentLoaded 724ms 40ms 699ms 1.00s 742ms 1.00s
firstPaint 75ms 13ms 60ms 192ms 88ms 192ms
firstContentfulPaint 75ms 13ms 60ms 192ms 88ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [593c5dd]
UI Startup Metrics (1296 ± 85 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1296114315968513541439
load111096313338211611267
domContentLoaded110495713128111551261
domInteractive201361101951
firstPaint58886135143710651238
backgroundConnect23822329310242254
firstReactRender2918135133147
getState199109112231
initialActions50193612
loadScripts8727401063809261034
setupStore1063231015
BrowserifyPower User HomeuiStartup21761784328854327903288
load1162937203334615322033
domContentLoaded1153932202434515212024
domInteractive291579194979
firstPaint43484999321965999
backgroundConnect25821737044291370
firstReactRender24223022430
getState18214826330200263
initialActions1028620786
loadScripts908712166231011921662
setupStore1081521015
WebpackStandard HomeuiStartup8637351155818821089
load64759094778647903
domContentLoaded63958593977639893
domInteractive15125781438
firstPaint19861914201188731
backgroundConnect24134982938
firstReactRender27174573334
getState1262341419
initialActions40153512
loadScripts63658392975636881
setupStore1051631215
WebpackPower User HomeuiStartup17531498234431221672344
load76864315062248781506
domContentLoaded72462713051758191305
domInteractive211457132357
firstPaint4488013113758231311
backgroundConnect12718486149110486
firstReactRender26233422734
getState15810629438155294
initialActions715714457
loadScripts71962512921718091292
setupStore13663141163
FirefoxBrowserifyStandard HomeuiStartup14421276191712014991702
load1221107914807612741367
domContentLoaded1220107914807612741367
domInteractive1153230248124226
firstPaint------
backgroundConnect4023106164774
firstReactRender26204972547
getState94126121015
initialActions611802137
loadScripts1195106314267312431339
setupStore136169181217
BrowserifyPower User HomeuiStartup27992273390241830433902
load14541272183614415811836
domContentLoaded14541272183614415801836
domInteractive1538930167223301
firstPaint------
backgroundConnect20741444133333444
firstReactRender39314964549
getState1498130362176303
initialActions15175221375
loadScripts13971239179313914861793
setupStore5061654892165
WebpackStandard HomeuiStartup16701443214012817241978
load14381278184510114911635
domContentLoaded14371278184510114901634
domInteractive1133339961115249
firstPaint------
backgroundConnect4524196225083
firstReactRender292381102944
getState104208201114
initialActions41425314
loadScripts1408125417939614551593
setupStore147104151327
WebpackPower User HomeuiStartup30542535431359134694313
load16641441205320418922053
domContentLoaded16631441205320418912053
domInteractive1557326860211268
firstPaint------
backgroundConnect26560796246546796
firstReactRender49331121951112
getState1537026647196266
initialActions912471624
loadScripts16001409191917418311919
setupStore401298245998
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 344 Bytes (0.01%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: fa8fc5c | Date: 10/27/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.02s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 713ms (±36ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.02s 39ms 1.00s 1.31s 1.06s 1.31s
domContentLoaded 713ms 36ms 695ms 984ms 729ms 984ms
firstPaint 75ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 75ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [fa8fc5c]
UI Startup Metrics (1268 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12681119192910113121398
load108795416719611271233
domContentLoaded108092616629611191226
domInteractive19146281838
firstPaint56587166744410761186
backgroundConnect23321737616235245
firstReactRender27184873143
getState20793112235
initialActions807412737
loadScripts8546971420958931001
setupStore1052741020
BrowserifyPower User HomeuiStartup19701690292937922822929
load1046850156826913711568
domContentLoaded1038844156126713611561
domInteractive301486224886
firstPaint47910115083878861508
backgroundConnect23617652796264527
firstReactRender24213122531
getState16612720018180200
initialActions1028319683
loadScripts836675130822910991308
setupStore1072341223
WebpackStandard HomeuiStartup806689114873835941
load59754794968607740
domContentLoaded58954091666594730
domInteractive15114271433
firstPaint21152957206174717
backgroundConnect23135482840
firstReactRender261663103145
getState1152741416
initialActions309248
loadScripts58653890564592723
setupStore941831214
WebpackPower User HomeuiStartup16881457228927017442289
load72163010471307931047
domContentLoaded686614939100763939
domInteractive19133793237
firstPaint506104946297773946
backgroundConnect1213241013390410
firstReactRender26234252642
getState1446316823157168
initialActions1611473616147
loadScripts68161292997750929
setupStore1172451424
FirefoxBrowserifyStandard HomeuiStartup14331259186312214811740
load1218108815138012711380
domContentLoaded1217108715138012701379
domInteractive1173330953126247
firstPaint------
backgroundConnect392593134767
firstReactRender25205862441
getState74545913
initialActions7118426311
loadScripts1193107114867812441328
setupStore145232241231
BrowserifyPower User HomeuiStartup28682340429063830984290
load14391258168412115301684
domContentLoaded14391258168312115301683
domInteractive17810041389254413
firstPaint------
backgroundConnect22938780226461780
firstReactRender423290144990
getState15410636864171368
initialActions915814758
loadScripts13811215160611814791606
setupStore3761464353146
WebpackStandard HomeuiStartup17651581249517317992200
load15031361200712115491785
domContentLoaded15031361200612115491785
domInteractive1213649767121285
firstPaint------
backgroundConnect5326177246199
firstReactRender31248593146
getState11514218921
initialActions7126527413
loadScripts14681338196411615001753
setupStore177157191658
WebpackPower User HomeuiStartup28992329488067433694880
load16431375232625718462326
domContentLoaded16421375232525718462325
domInteractive15676441106280441
firstPaint------
backgroundConnect22430979271284979
firstReactRender423270105070
getState1337421338175213
initialActions612061120
loadScripts15791344205320617582053
setupStore4192816638281
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 100 Bytes (0%)
  • ui: -17 Bytes (0%)
  • common: -210 Bytes (0%)

Copy link
Contributor

@AugmentedMode AugmentedMode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mindofmar mindofmar added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@mindofmar mindofmar added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@mindofmar mindofmar added this pull request to the merge queue Oct 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2025
@mindofmar mindofmar enabled auto-merge October 30, 2025 22:57
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: f5dc4d9 | Date: 10/30/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 974ms (±39ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 677ms (±36ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 73ms (±10ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 974ms 39ms 944ms 1.23s 1.02s 1.23s
domContentLoaded 677ms 36ms 654ms 920ms 709ms 920ms
firstPaint 73ms 10ms 60ms 164ms 84ms 164ms
firstContentfulPaint 73ms 10ms 60ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [f5dc4d9]
UI Startup Metrics (1295 ± 99 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1295113015489913671458
load110496213669011641261
domContentLoaded109795913608911591255
domInteractive20146992143
firstPaint60692127045011321240
backgroundConnect23221730411235252
firstReactRender30195583547
getState2295372535
initialActions917512928
loadScripts8727401128899331020
setupStore1162431219
numNetworkReqs96327630
BrowserifyPower User HomeuiStartup22601827412365026354123
load1196950218936215902189
domContentLoaded1187944216936015842169
domInteractive31171002246100
firstPaint713248217851110032178
backgroundConnect271217722118254722
firstReactRender27233232832
getState18315426525196265
initialActions824811648
loadScripts943730174231713111742
setupStore15845101445
numNetworkReqs357141710180520710
WebpackStandard HomeuiStartup855739108060881957
load63659388858648761
domContentLoaded62958687858641752
domInteractive15115681436
firstPaint21055882218194755
backgroundConnect23115372635
firstReactRender27175283335
getState1262341517
initialActions3014247
loadScripts62558486755639741
setupStore1051531214
numNetworkReqs96378633
WebpackPower User HomeuiStartup16031209258149622772581
load75460212622158511262
domContentLoaded71459210951638121095
domInteractive18124892048
firstPaint3727510983536471098
backgroundConnect12111479166322479
firstReactRender26235472654
getState15312519515159195
initialActions605713557
loadScripts71059010841598011084
setupStore13648121148
numNetworkReqs296119750208521750
FirefoxBrowserifyStandard HomeuiStartup15451341216112615901759
load1309113515488613601479
domContentLoaded1309113315488613601478
domInteractive1233536146134212
firstPaint------
backgroundConnect50282002853127
firstReactRender27225372750
getState74193814
initialActions4192949
loadScripts1278111015138213301424
setupStore1273641221
numNetworkReqs96357730
BrowserifyPower User HomeuiStartup26632137442660330434426
load13981184188918214751889
domContentLoaded13981184188918214751889
domInteractive1819533495307334
firstPaint------
backgroundConnect2343413303233651330
firstReactRender37295374353
getState1267718226138182
initialActions11150142150
loadScripts13141106162413514191624
setupStore2851302938130
numNetworkReqs23489679149298679
WebpackStandard HomeuiStartup15981427193610116571818
load1379122616478814251580
domContentLoaded1378122616478814251580
domInteractive1043033748110230
firstPaint------
backgroundConnect4626110165382
firstReactRender312275123072
getState84495814
initialActions4152649
loadScripts1351120916098613931550
setupStore1275571221
numNetworkReqs96336727
WebpackPower User HomeuiStartup27232237369944131593699
load15551247206122417692061
domContentLoaded15551246206022417692060
domInteractive1507235379206353
firstPaint------
backgroundConnect19034679187317679
firstReactRender39315184851
getState1256819834136198
initialActions815914559
loadScripts15111225193821017261938
setupStore22953133553
numNetworkReqs240115539122281539
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 110 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@mindofmar mindofmar added this pull request to the merge queue Oct 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: dd1fcf5 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 719ms (±37ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±15ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 41ms 1.01s 1.33s 1.06s 1.33s
domContentLoaded 719ms 37ms 698ms 1.00s 743ms 1.00s
firstPaint 77ms 15ms 60ms 212ms 84ms 212ms
firstContentfulPaint 77ms 15ms 60ms 212ms 84ms 212ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [dd1fcf5]
UI Startup Metrics (1332 ± 89 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1332118916118913881504
load113497514058811901277
domContentLoaded112696313968911851270
domInteractive241595132347
firstPaint63792140847211671276
backgroundConnect24622335119254270
firstReactRender3417136183956
getState21886102533
initialActions71436818
loadScripts8877101151889461048
setupStore1164851319
numNetworkReqs96327630
BrowserifyPower User HomeuiStartup23031864353763132573537
load1212985187034117131870
domContentLoaded1201978185033716991850
domInteractive271756155056
firstPaint883199188357010661883
backgroundConnect26422253372276533
firstReactRender27253322833
getState18013825925194259
initialActions1337320773
loadScripts961758158131513951581
setupStore1292741227
numNetworkReqs334167697206670697
WebpackStandard HomeuiStartup8637331149828721076
load64759094772648867
domContentLoaded63958591671642858
domInteractive16114271435
firstPaint20757948197198624
backgroundConnect23116192643
firstReactRender27176183235
getState1252941518
initialActions308247
loadScripts63658390569640847
setupStore1052131214
numNetworkReqs106358832
WebpackPower User HomeuiStartup17571434258538622602585
load74664010701398801070
domContentLoaded713623986115834986
domInteractive211453112953
firstPaint4689210723408391072
backgroundConnect12622528154139528
firstReactRender28234962749
getState16012223924163239
initialActions170121339121
loadScripts709621975111823975
setupStore3062055226205
numNetworkReqs338201696174559696
FirefoxBrowserifyStandard HomeuiStartup1418126318158914731578
load1208108113616712431341
domContentLoaded1207108013616712431341
domInteractive1113729445121223
firstPaint------
backgroundConnect3923116134460
firstReactRender26206182647
getState84587917
initialActions4139449
loadScripts1185105713336512241315
setupStore136184181220
numNetworkReqs96348731
BrowserifyPower User HomeuiStartup27872275349638331983496
load14301240176913415391769
domContentLoaded14301240176813415381768
domInteractive16410728858185288
firstPaint------
backgroundConnect26246875211435875
firstReactRender412980124680
getState1268117826147178
initialActions1418224882
loadScripts13731202168012814841680
setupStore2791172534117
numNetworkReqs24014232669309326
WebpackStandard HomeuiStartup16541470211712116732003
load1414123417888714651584
domContentLoaded1414123317888714651584
domInteractive1113441360114258
firstPaint------
backgroundConnect4827115195592
firstReactRender3524124183579
getState10515019815
initialActions6112316314
loadScripts1385121517588614311562
setupStore156208211341
numNetworkReqs96367731
WebpackPower User HomeuiStartup28732300384549834643845
load16231308204724818622047
domContentLoaded16231307204624818622046
domInteractive1477923850202238
firstPaint------
backgroundConnect23254625200399625
firstReactRender43326084860
getState1296620133148201
initialActions13230102230
loadScripts15621266196322518081963
setupStore5482296148229
numNetworkReqs275136545128364545
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 110 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [6eebe10]
UI Startup Metrics (1240 ± 86 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1240109615658613021382
load105992513558111051185
domContentLoaded105391913458011011180
domInteractive20146091846
firstPaint59673125143310701174
backgroundConnect2272142466231237
firstReactRender2917131133248
getState21974102539
initialActions70496717
loadScripts832695112280876963
setupStore1172841220
numNetworkReqs96327630
BrowserifyPower User HomeuiStartup22041837318354531093183
load1172960186432716871864
domContentLoaded1160955183331916271833
domInteractive281565174465
firstPaint804165186751110021867
backgroundConnect25122433431274334
firstReactRender26233122731
getState17014319012179190
initialActions63245524
loadScripts922736152529813711525
setupStore1282541225
numNetworkReqs339181704205676704
WebpackStandard HomeuiStartup8547221162778801021
load63958197873648834
domContentLoaded63157696971641827
domInteractive15117791434
firstPaint18856963189196624
backgroundConnect23125792646
firstReactRender27175883239
getState1255051520
initialActions3015247
loadScripts62757495869639815
setupStore1052331216
numNetworkReqs96328832
WebpackPower User HomeuiStartup15901203235234720592352
load68557812651797241265
domContentLoaded64656411371416861137
domInteractive18123482734
firstPaint4617911413177261141
backgroundConnect12512403142339403
firstReactRender25214762447
getState1508823632144236
initialActions1015718457
loadScripts64256211291396781129
setupStore23582272782
numNetworkReqs334195695169575695
FirefoxBrowserifyStandard HomeuiStartup15611293205513516511793
load13151118171810313751478
domContentLoaded13141118171810313741477
domInteractive1243537658133225
firstPaint------
backgroundConnect49251732554110
firstReactRender28216472846
getState10411015816
initialActions4213247
loadScripts12871102168610013501447
setupStore176205271430
numNetworkReqs96358733
BrowserifyPower User HomeuiStartup27692257350837930963508
load14531191204119815632041
domContentLoaded14521191204019815632040
domInteractive20395814169249814
firstPaint------
backgroundConnect21539585182382585
firstReactRender443189145089
getState1228023637136236
initialActions2212185215218
loadScripts13991165199719715101997
setupStore3561383840138
numNetworkReqs2329141789294417
WebpackStandard HomeuiStartup16191422230216316282001
load13771189182611314231597
domContentLoaded13771189182511314231597
domInteractive1113251278110355
firstPaint------
backgroundConnect49221792754126
firstReactRender3523106163477
getState104200201019
initialActions6113516316
loadScripts13481167176510913971566
setupStore157207221333
numNetworkReqs106388732
WebpackPower User HomeuiStartup27172290391443429483914
load16001305231228217982312
domContentLoaded16001305231128217982311
domInteractive1655036092262360
firstPaint------
backgroundConnect17334775213177775
firstReactRender42325274952
getState1438521342185213
initialActions1116516965
loadScripts15481277201024017672010
setupStore3781383558138
numNetworkReqs269153532114343532
📊 Page Load Benchmark Results

Current Commit: 6eebe10 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 717ms (±36ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±14ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 40ms 1.01s 1.33s 1.07s 1.33s
domContentLoaded 717ms 36ms 697ms 988ms 742ms 988ms
firstPaint 76ms 14ms 56ms 200ms 84ms 200ms
firstContentfulPaint 76ms 14ms 56ms 200ms 84ms 200ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 110 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@mindofmar mindofmar added this pull request to the merge queue Oct 31, 2025
Merged via the queue into main with commit b50a9d9 Oct 31, 2025
173 checks passed
@mindofmar mindofmar deleted the fix/phishing-page-proceed-anyway branch October 31, 2025 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2025
@metamaskbot metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-13.9.0 Issue or pull request that will be included in release 13.9.0 size-S team-product-safety Push issues to Product Safety team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants